Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
|
Contributor
Author
|
/ok to test |
mdboom
added
cuda.bindings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a number of issues with the
cuda_bindingsexamples that were hard to separate out.cuda_bindingsexamples are now run as part of the test suite, rather than a separate step in CI. This should make local testing of the examples easier (and is also in-line with whatcuda.corecurrently does).cuda_bindingsitself. This does (unfortunately) mean that the examples require a /very/ recent version ofcuda_bindings, but this is still probably preferable to a pile of code you have to copy manually to your local disk.pytestand callpytest.skip. This is now handled with a special exit code when being run from the test suite, so that the examples can run standalone without needing to installpytestin the local environment.