[no-ci] Fix blocked-label check falsely matching "documentation"#1836
Open
rwgk wants to merge 1 commit intoNVIDIA:mainfrom
Open
[no-ci] Fix blocked-label check falsely matching "documentation"#1836rwgk wants to merge 1 commit intoNVIDIA:mainfrom
rwgk wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
The blocked-patterns loop word-split "DO NOT MERGE" into individual words, so "DO" matched as a substring of "documentation" via grep. Replace with a single grep -qiE regex and read labels line-by-line from jq to also handle multi-word label names correctly. Made-with: Cursor
rwgk
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The blocked-label check in
pr-metadata-check.ymlword-split the string"blocked DO NOT MERGE do not merge"into individual shell tokens (blocked,DO,NOT,MERGE,do,not,merge). Each token was then used as agrep -qisubstring pattern, soDOmatcheddocumentation, causing a false "Blocked label detected" error on any PR with thedocumentationlabel.Fix
Replace the double-nested word-split loop with:
while IFS= read -rloop overjq -r '.[].name'output, correctly handling multi-word label namesgrep -qiE "blocked|do not merge"regex, keeping multi-word patterns intactWorkflow logs reviewed while working on this PR
documentation,cuda.bindingsdocumentationflaggedenhancement,feature,cuda.bindings