Fix Cython compilation warnings in cuda.core#1834
Merged
Andy-Jost merged 1 commit intoNVIDIA:mainfrom Mar 31, 2026
Merged
Conversation
- cimport Buffer and MemoryResource into _device.pyx to resolve unknown type annotations - Quote forward-reference annotations (Graph, LinkerOptions, DevicePointerT) that Cython cannot resolve at compile time - Remove duplicate MRDeallocCallback ctypedef from _resource_handles.pyx (already declared in .pxd) Made-with: Cursor
Andy-Jost
added
P1
rwgk
approved these changes
Mar 30, 2026
This comment has been minimized.
This comment has been minimized.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates all 8 Cython-level compilation warnings emitted during the
cuda.corebuild.Changes
_device.pyx—cimport Buffer, MemoryResourcefrom_buffer.pxdto resolve "Unknown type declaration" warnings (no circular dependency)_graph_builder.pyx— quote"Graph"in two return annotations (plain Python class, cannot be cimported)_linker.pyx— quote"LinkerOptions"in__init__annotation (dataclass defined in same file)_memory_pool.pyx,_graph_memory_resource.pyx— quote"DevicePointerT"indeallocateannotation (Python type alias, cannot be cimported)_resource_handles.pyx— remove duplicateMRDeallocCallbackctypedef (already declared in.pxd)Test Plan
Made with Cursor