NVIDIA: SAUCE: nvme-pci: fix NVFS SGL pool selection and DMA iter leak#333
Open
sourabgupta3 wants to merge 1 commit intoNVIDIA:24.04_linux-nvidia-6.17-nextfrom
Conversation
For NVFS I/Os, blk_rq_nr_phys_segments() can undercount GPU physical segments since CPU-side segment contiguity may differ from GPU physical contiguity. This can undersize the SGL pool causing a buffer overrun. Use payload size to select the pool: small (16 entries) for < 15*64K, large (256 entries) otherwise, bounded by actual pool capacity. Also guard nvfs_blk_rq_dma_map_iter_next() with mapped < entries so we never create a DMA mapping that cannot be stored or unmapped, which would leave nvfs_n_ops elevated and block nvfs_exit() on rmmod. Signed-off-by: Sourab Gupta <sougupta@nvidia.com> Reviewed-by: Kiran Modukuri <kmodukuri@nvidia.com>
sourabgupta3
force-pushed
the
sg_24.04_linux-nvidia-6.17-next-nvme-fix
branch
from
00f1a56 to
f3872dd
Compare
Collaborator
|
|
nirmoy
approved these changes
Mar 8, 2026
Collaborator
nirmoy
left a comment
nirmoy
left a comment
There was a problem hiding this comment.
Acked-by: Nirmoy Das <nirmoyd@nvidia.com>
Collaborator
jamieNguyenNVIDIA
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For NVFS I/Os, blk_rq_nr_phys_segments() can undercount GPU physical segments since CPU-side segment contiguity may differ from GPU physical contiguity. This can undersize the SGL pool causing a buffer overrun.
Use payload size to select the pool: small (16 entries) for < 15*64K, large (256 entries) otherwise, bounded by actual pool capacity.
Also guard nvfs_blk_rq_dma_map_iter_next() with mapped < entries so we never create a DMA mapping that cannot be stored or unmapped, which would leave nvfs_n_ops elevated and block nvfs_exit() on rmmod.
Signed-off-by: Sourab Gupta sougupta@nvidia.com
Reviewed-by: Kiran Modukuri kmodukuri@nvidia.com