Skip to content

Conversation

@apaithankar
Copy link

@apaithankar apaithankar commented Dec 24, 2025

Adds a retry loop to filesystemAsyncWriter for each item that generates an exception.

What does this PR do ?

Implement retry loop in write_preloaded_data() to handle failures during checkpoint saves.
Logging for item write retry attempts and final failures.
Updated unit tests

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either [email protected] or [email protected].

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@apaithankar apaithankar requested review from a team as code owners December 24, 2025 03:04
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 24, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot requested a review from Phlip79 December 24, 2025 03:04
# Reset results for each retry attempt
local_results = []

with open_file(file_name, "wb") as stream:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of trying to write the whole file every attempt, Can you use io.ByteIO in some number of buffers and apply retrying the write and fsync on each buffer?
_write_item calls torch.save which computes CRC32 of the tensor and do write.
So, if we retry the whole steps, then we will do this computation again.

What we want to achieve here is to have resiliency in the filesystem backend.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@apaithankar apaithankar force-pushed the retry-checkpoint-saves branch from 0d62973 to 4e2a97b Compare December 24, 2025 23:32
@apaithankar apaithankar requested a review from sbak5 December 24, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants