-
Notifications
You must be signed in to change notification settings - Fork 16
fix(utils): vim.validate upgrade
#66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi, thanks for doing this! Do you mind doing it without version-specific code (since I don't want to maintain that kind of stuff), and I'll merge it when the |
Excellent! 1 minute and it's done! |
|
1 sec. |
|
Done. If there are any suggestions I'll be here. |
|
That being said, I'm not exactly sure how to deal with that |
|
Thanks for the lightning-fast response!!
The only (possibly) better solution I can think of is to make local unpack = unpack or table.unpackIt doesn't change functionality, it makes more sense, and it removes warnings. Also, since your update is focused on removing deprecation warnings, you should put your old title for PR back. Other than that, this looks pretty good! |
vim.validate upgrade
7b6056d to
4694070
Compare
|
@NStefan002 All set! Also reverted my |
|
Thanks for doing this! Will merge as soon as the |
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
Signed-off-by: Guennadi Maximov C <[email protected]>
4694070 to
b657ae9
Compare
Signed-off-by: Guennadi Maximov C <[email protected]>
@NStefan002 As a bleeding edge user, nothing wrong so far! |
✅ Checklist
📝 Description
I use Neovim >0.11. When checking the output of
:checkhealth vim.deprecatedI got the following:As
:h vim.validate()suggests, the usage ofvim.validate({ ... })is deprecated since Neovimv0.11.Therefore I took the liberty to modify
utils.luato account for the new versionswithout dropping support for older versions:Now I get no deprecation warnings when using this plugin:
screenkey_health.mp4