-
Notifications
You must be signed in to change notification settings - Fork 23
Move Unit from Energy to Core #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #271 +/- ##
============================================
+ Coverage 13.58% 13.74% +0.16%
- Complexity 732 762 +30
============================================
Files 409 413 +4
Lines 12788 13010 +222
Branches 1354 1380 +26
============================================
+ Hits 1737 1788 +51
- Misses 10934 11107 +173
+ Partials 117 115 -2
Continue to review full report at Codecov.
|
de1de1e to
7504084
Compare
| public final class Unit implements Identifiable { | ||
| private static final Registry<Unit> REGISTRY = new Registry<>(); | ||
|
|
||
| public static final Unit METRE = getOrCreateUnit("nova:metre", "Meter", "m"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Meter/Metre/ please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll make use of the Translateable interface
|
Changes implemented and rebased to master |
…r being instantiated
The requested changes have been addressed
This PR will move
Unitfrom Energy to Core.Reason:
Unitseems like a class that would benefit more from being in Core than in Energy.Other changes:
UnitDisplayis now immutable, and accepts aDoubleSupplierto allow linking to a getter.Example:
Modded Minecraft energy units were left out and will be added by NOVA-Team/NOVA-Energy#3.