Skip to content

Conversation

@amschne
Copy link
Collaborator

@amschne amschne commented Apr 22, 2025

Support for GSI stats radiance monitoring figures and minor updates to replay file count and increment plots.

GSIstats figures:

  • preexisting GSI stats plot capabilities from gsistats_timeseries.py moved to gsistats_plot_utils.py
  • small changes to gsistats_timeseries.py to preserve existing capabilities and improve speed of new plot features
  • instrument_channel_nums.py library
  • satellite_names.py library
  • new mega-plot generation driver routines in plot_gsi_radiance_fit_to_obs.py and sbatch submission script
  • example calling function for a subset of sensors in plot_gsi_radiance_fit_to_obs_daily_update.py and corresponding sbatch submission script

Replay figure updates:

  • addition of replay forward extension experiment to request dicts in plot_file_counts.py and plot_increments.py
  • logic needed to define improved figure and axes titles

Also includes new matplotlib style sheets for better web appearance

Example figures available at https://psl.noaa.gov/UFS/

jrknezha and others added 30 commits January 15, 2025 15:53
…(mean, rms) errors, organized by sensor and platform for reanalysis experiment inter-comparisons
…explicit mpi4py send/recv (instead of bcast) calls to distribute filtered data frames to child processes
@amschne amschne changed the title Beta test/file counts replay inc gsi brightness temp GSI stats radiance monitoring figures and minor updates to replay file count and increment plots Apr 22, 2025
@amschne amschne changed the title GSI stats radiance monitoring figures and minor updates to replay file count and increment plots Web monitoring figures for GSI brightness temperature errors and replay file counts and increments Apr 22, 2025
@amschne amschne marked this pull request as ready for review July 15, 2025 19:27
@amschne amschne self-assigned this Aug 12, 2025

from score_db import score_db_base

def run(make_plot=False, make_line_plot=True, select_array_metric_types=True,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please clean up some of the comments in this function and run_line_plot? That will clear up how these functions work a bit.



def main():
#run()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the run() function get called at all? If not, that can be removed.


self.timestamp_dict = dict()
self.timelabel_dict = dict()
#self.timelabel_dict = dict()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments in this function need to be cleaned up.

def main():
"""
"""
#run_avhrr()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these comments used to run different plot types? If so, can you please document that at the top of main, or make it a CLI argument to swap between plot types?

else:
title_str1 = "]"

#fig.suptitle(f"{title_str0}{title_str1}")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few comments in this function that should be cleaned up.

Copy link
Collaborator

@KevinCounts KevinCounts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added comments to a few spots where comments should be cleaned up and main functions that need some documentation. I know one of those scripts is legacy. Other than those, I think this is looking great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants