Update to 0.12 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogambro
commented
Nov 14, 2023
| fn add(&mut self, asset: Image) -> Handle<Image>; | ||
| /// Get a texture from the store | ||
| fn get<H: Into<HandleId>>(&self, handle: H) -> Option<&Image>; | ||
| fn get<H: Into<Handle<Image>>>(&self, handle: H) -> Option<&Image>; |
Author
There was a problem hiding this comment.
Note that this is Handle<Image> now... I wasn't sure whether we would prefer to store AssetId<Image> instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty self explanatory :)
Before (0.11):
After (0.12):
As the default clear color changed, the background is different. I changed it locally, to check if the image really is the same and nothing out of the ordinary broke, BUT I did not set the clear color to the old value, to respect bevy's new choice of default clear color.
Have a wonderful day!