Skip to content

Conversation

@nth10sd
Copy link
Contributor

@nth10sd nth10sd commented May 12, 2018

This PR:

I had to work around an issue involving optparse and pathlib so eventually we'll have to move everything to argparse.

I added some tests but I could definitely add more. Basic tests are passing but I haven't yet tested more, and there are likely to be more bugs lurking.

This is an early version to give ample time for feedback.

@nth10sd nth10sd self-assigned this May 12, 2018
@nth10sd nth10sd requested a review from jschwartzentruber May 12, 2018 01:47
@codecov-io
Copy link

codecov-io commented May 12, 2018

Codecov Report

Merging #198 into master will increase coverage by 5.15%.
The diff coverage is 50.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   44.17%   49.32%   +5.15%     
==========================================
  Files          31       37       +6     
  Lines        2685     2810     +125     
==========================================
+ Hits         1186     1386     +200     
+ Misses       1499     1424      -75
Impacted Files Coverage Δ
src/funfuzz/js/js_interesting.py 21.42% <10.52%> (-1.03%) ⬇️
src/funfuzz/util/s3cache.py 54.23% <100%> (ø) ⬆️
src/funfuzz/js/__init__.py 100% <100%> (ø) ⬆️
src/funfuzz/ccoverage/get_build.py 100% <100%> (ø) ⬆️
src/funfuzz/js/shell_flags.py 89.93% <100%> (-0.07%) ⬇️
tests/util/test_fork_join.py 100% <100%> (ø)
tests/js/test_link_fuzzer.py 100% <100%> (ø)
tests/util/test_sm_compile_helpers.py 100% <100%> (ø)
tests/util/test_os_ops.py 100% <100%> (ø)
tests/util/test_hg_helpers.py 100% <100%> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b5e09...79eb6a9. Read the comment docs.

nth10sd added 28 commits June 1, 2018 18:38
…reated returns its result in the form of a Path.
@nth10sd nth10sd merged commit 4abb66c into MozillaSecurity:master Jun 3, 2018
@nth10sd nth10sd deleted the pathlib-usage branch June 3, 2018 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants