Music and sound effects label added to sliders #216
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added labels for music and sound effects options in the UI.
Collaborator
|
I agree with the update, but you also need to ensure all subsequent chapters are reviewed for the update and we will need an accompanying PR on the samples repo to also update the code in this and all subsequent chapters, if that's ok |
Contributor
Author
|
That's more than okay! I'll review the subsequent chapters and create the
relevant PRs as needed.
…On Mon, Dec 8, 2025 at 4:42 AM Simon (Darkside) Jackson < ***@***.***> wrote:
*SimonDarksideJ* left a comment (MonoGame/docs.monogame.github.io#216)
<#216 (comment)>
I agree with the update, but you also need to ensure all subsequent
chapters are reviewed for the update and we will need an accompanying PR on
the samples repo to also update the code in this and all subsequent
chapters, if that's ok
—
Reply to this email directly, view it on GitHub
<#216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACFLY656PA7CJESAE642XCL4AVIZPAVCNFSM6AAAAACNNRHKBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMMRWGI2DSNJRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
|
I checked the other chapters and if it were to be added here it would be later removed in Chapter 21 as that seems to be where the UI gets the proper styling. This code would only be called in the creationOptionsPanel(). |
Contributor
|
I see that the changes for this PR would get undone in the later versions where styling is applied, so that's good - the changes are minimal. I believe the samples repo must also be updated for this chapter: |
Collaborator
|
OK, will merge this when I get a minute to update all the samples this change affects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see it's handled later in Chapter 21 when it is stylized but I thought it'd be handy to add a label to the two sliders so the tutorial learner knows which slider affects music and sfx.