recover scheduler infer_step

[wangshankun]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @wangshankun, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the scheduler within the lightx2v model. It introduces the initialization of infer_steps and caching_records to ensure the scheduler can properly recover and maintain state during the inference process. This change aims to improve the reliability and stability of the model's inference steps.

Highlights

• Scheduler Recovery: This PR initializes infer_steps and caching_records in the scheduler to recover the scheduler's inference process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• scheduler.py
  • Initialized infer_steps and caching_records.

Activity

• The author, wangshankun, has made changes to the scheduler.py file to initialize infer_steps and caching_records.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds the infer_steps and caching_records attributes to the BaseScheduler, which appears to be a necessary fix. My review includes a suggestion to add validation for the infer_steps configuration value to improve the code's robustness against invalid inputs, ensuring it is always a positive integer.

[gemini-code-assist]

For improved robustness, it's good practice to validate configuration values. This change uses config.get() to safely retrieve infer_steps and adds validation to ensure it's a positive integer. This prevents potential KeyError exceptions for missing keys and handles invalid values like zero, negative numbers, or non-integers, making the scheduler more resilient to configuration errors.

Suggested change

	self.infer_steps = config["infer_steps"]
	self.caching_records = [True] * config["infer_steps"]
	self.infer_steps = config.get("infer_steps")
	if not isinstance(self.infer_steps, int) or self.infer_steps <= 0:
	raise ValueError(f"'infer_steps' must be a positive integer, but got {self.infer_steps!r}")
	self.caching_records = [True] * self.infer_steps