fix(qt): guard AA_EnableHighDpiScaling for Qt6 #2283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This branch of MO2 is not meant to be build with Qt5 so if the line is not needed anymore with Qt6 then the best thing to do is completely remove it. |
Contributor
Author
|
@Holt59 Done. I've removed the line completely as you suggested. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps QApplication::setAttribute(Qt::AA_EnableHighDpiScaling) with a version check.
In Qt6, high-DPI scaling is always enabled by default, so calling this attribute is unnecessary and produces a deprecation warning. This change removes the warning for Qt6 builds while maintaining compatibility with Qt5.
Tested with Qt 6.7 and VS2022. The warning is gone and UI scaling behavior is unchanged.