[Feature] Retry Mechanism and Error UI Added in Services Webview #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfreitas
approved these changes
Jan 22, 2025
feature/src/main/java/au/com/alfie/ecomm/feature/webview/component/WebView.kt
Outdated
Show resolved
Hide resolved
feature/src/main/java/au/com/alfie/ecomm/feature/webview/component/WebView.kt
Outdated
Show resolved
Hide resolved
…=' into feature/ALFMOB-79_retry_services_feature # Conflicts: # feature/src/main/java/au/com/alfie/ecomm/feature/webview/component/WebView.kt
feature/src/main/java/au/com/alfie/ecomm/feature/webview/WebViewContent.kt
Show resolved
Hide resolved
* chore: Added git hooks, setup CI/CD, fastlane with firebase uploading of builds
* chore: Detekt issues and Ci/CD fixed
…=' into feature/ALFMOB-79_retry_services_feature
designsystem/src/main/java/au/com/alfie/ecomm/designsystem/component/dialog/ErrorScreen.kt
Outdated
Show resolved
Hide resolved
feature/webview/src/main/java/au/com/alfie/ecomm/feature/webview/WebViewScreen.kt
Show resolved
Hide resolved
rsousamindera
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In services tab, when webpage cannot load, instead of showing webpage default error, now we are showing a proper message with a retry button similar to the iOS app.
Screenshots