[fork CI] Validate term() guards for SUv4 backport#2
Draft
MilesCranmerBot wants to merge 17 commits intorelease-v1from
Draft
[fork CI] Validate term() guards for SUv4 backport#2MilesCranmerBot wants to merge 17 commits intorelease-v1from
MilesCranmerBot wants to merge 17 commits intorelease-v1from
Conversation
Restore index_functions round-trip for custom operators under SymbolicUtils v4.
Adds SymbolicUtils.term() usage to prevent SUv4 from canonicalizing x*x to x^2 during conversion. This makes the backport behaviorally equivalent to upstream/master. - Import term from SymbolicUtils - Use term(op, ...) for * and + in parse_tree_to_eqs - Use term(*, ...) in multiply_powers to build explicit products - Restore test to check x1*x1 stays as explicit multiplication
JET flagged "local variable may be undefined" in src/precompile.jl when iterating over a Vector of types.\n\nUse a tuple for the type loop and initialize so the value is always defined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validates the term() guard fix before upstream PR SymbolicML#161.