Skip to content

ci: fix Julia 1.12 CI regressions (fork)#1

Open
MilesCranmerBot wants to merge 14 commits intorelease-v1from
bot/ci-fix-pr161
Open

ci: fix Julia 1.12 CI regressions (fork)#1
MilesCranmerBot wants to merge 14 commits intorelease-v1from
bot/ci-fix-pr161

Conversation

@MilesCranmerBot
Copy link
Owner

Fork-only PR to validate CI fixes before pushing anything to upstream PR SymbolicML#161.

Fixes:

  • JET test compatibility with newer JET
  • chainrules test: avoid evaluating on Node in bad_op
  • buffered eval tests: treat NaNs as equal when both sides produce them

- Update JET test to handle newer JET APIs
- Avoid calling bad_op(::Node) in chainrules tests
- Make buffered evaluation comparisons NaN-stable
Initialize locals for static analysis in operator enum extension machinery and precompile helpers, and narrow ValueInterface check helpers to Number.
Only compare buffered/non-buffered results when both evaluations succeeded; and make ValueInterface pack/unpack interface checks generic so non-Number implementers (e.g. DynamicTensor) pass.
Use invokelatest + try/catch in interface checker helpers to avoid JET false-positives for non-ValueInterface types while keeping runtime behavior for real implementers.
Guard pack/unpack check helpers with applicable() and ensure they return Bool without broad exception-based control flow.
Avoid logging/exception widening in get_number_type checker and add ValueInterfaceModule to JET ignored_modules to prevent false positives from interface test helpers.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 22034398761

Details

  • 76 of 78 (97.44%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on bot/ci-fix-pr161 at 97.191%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ValueInterface.jl 17 19 89.47%
Totals Coverage Status
Change from base Build 22019245733: 97.2%
Covered Lines: 2595
Relevant Lines: 2670

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants