-
-
Notifications
You must be signed in to change notification settings - Fork 100
Bump @metamask/snaps-rpc-methods from 13.5.1 to 13.5.3 #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bump @metamask/snaps-rpc-methods from 13.5.1 to 13.5.3 #447
Conversation
Bumps [@metamask/snaps-rpc-methods](https://github.com/MetaMask/snaps) from 13.5.1 to 13.5.3. - [Release notes](https://github.com/MetaMask/snaps/releases) - [Commits](https://github.com/MetaMask/snaps/compare/@metamask/[email protected]...@metamask/[email protected]) --- updated-dependencies: - dependency-name: "@metamask/snaps-rpc-methods" dependency-version: 13.5.3 dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
|
Caution MetaMask internal reviewing guidelines:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
| "@metamask/rpc-errors": ^7.0.3 | ||
| "@metamask/snaps-sdk": ^9.3.0 | ||
| "@metamask/snaps-utils": ^11.5.0 | ||
| "@metamask/snaps-sdk": ^10.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major version conflict in snaps-sdk dependencies
High Severity
The dependency update creates a major version conflict for @metamask/snaps-sdk. The upgraded @metamask/[email protected] now depends on @metamask/snaps-sdk@^10.0.0 (resolving to 10.4.0), but @metamask/[email protected] still directly depends on @metamask/snaps-sdk@^9.3.0. This results in three different versions of the SDK in the dependency tree (9.3.0, 10.3.0, and 10.4.0), causing potential runtime errors, type mismatches, instanceof failures, and increased bundle size.
Bumps @metamask/snaps-rpc-methods from 13.5.1 to 13.5.3.
Commits
3fda705release:128.0.0(#3690)fff1ef6chore: Revert "release: 128.0.0 (#3685)" (#3688)e246ad7release: 128.0.0 (#3685)aa6cc78docs(contributing): update Node.js version to 20 to match engines (#3604)1f14fa8fix: Wait for unlock before handlingmanageAccountsrequests (#3686)ea29b05chore: Bump@metamask/approval-controllerfrom 7.1.3 to 7.2.0 (#3671)6f54282chore: make@metamask/test-snaps-sitepublishable (#3679)9aa68cdfix: Throw if Snap not installed (#3666)5d19c66chore: Bump@metamask/json-rpc-middleware-streamfrom 8.0.7 to 8.0.8 (#3670)2c9481achore: Bump@metamask/controller-utilsfrom 11.14.0 to 11.14.1 (#3676)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Dependency update
@metamask/snaps-rpc-methodsfrom13.5.1to13.5.3@metamask/snaps-sdkto^10(locks to10.4.0),@metamask/utilsto^11.8.1/11.9.0, and adjusts@metamask/snaps-utilsrangesWritten by Cursor Bugbot for commit 773f902. This will update automatically on new commits. Configure here.