fix: handle extreme token amounts to prevent NaN and scientific notation #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extreme token amounts caused two issues: - "You receive" showed NaN when parseFloat returned invalid values - Transaction history failed StringNumber validation due to scientific notation Add validation for parsed values in TransactionScanService and use BigNumber's toFixed() in TransactionsMapper to ensure decimal string output.
ulissesferreira
force-pushed
the
NEB-386/fix-nan-display-and-scientific-notation
branch
from
a14470c to
b247f93
Compare
ulissesferreira
commented
Feb 3, 2026
| @@ -14,7 +14,7 @@ import type { | |||
| import type { Network } from '../../constants'; | |||
Contributor
Author
There was a problem hiding this comment.
Leverage our utility to adjust decimals powered by BigNumber.js to make sure we have no problems on transactions mapping because we were mapping some to use scientific notation (as seen here https://consensys.slack.com/archives/C09QLE417UY/p1769521271407099?thread_ts=1769503457.145259&cid=C09QLE417UY). The problem with scientific notation is it gets rejected by the client's StringNumber validation. The Snap needs to send the value as-is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extreme token amounts caused two issues:
Add validation for parsed values in TransactionScanService and use BigNumber's toFixed() in TransactionsMapper to ensure decimal string output.