fix: gracefully handle dismissed interface contexts during background… #188
+69
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulissesferreira
commented
Feb 4, 2026
| confirmationInterfaceId, | ||
| ); | ||
|
|
||
| if (!latestContext) { |
Contributor
Author
There was a problem hiding this comment.
@mikesposito had asked if this made sense since the types stated that we always had something... Confirmed it can come in as null in the documentation here and confirmed that the code is indeed giving us the wrong type, never mentioning null. Worth pointing it out to the Snaps team so they can fix it.
… refresh Ports a fix from Solana Snap to handle cases where users close dialogs before async operations (price fetching, security scanning) complete. - Re-check interface context after async operations in cronjob.tsx - Add null check after security scan in render.tsx - Add test for graceful exit when interface is closed during scan
ulissesferreira
force-pushed
the
NEB-322-fix-handle-dismissed-interface-contexts
branch
from
0388c26 to
3c5c835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… refresh
Ports a fix from Solana Snap to handle cases where users close dialogs before async operations (price fetching, security scanning) complete.