feat(STX-331): migrate STX flags to smart-transactions-controller

[rarquevaux]

RemoteFeatureFlagController Integration in SmartTransactionController

This PR refactors how Smart Transactions feature flags are validated and made available to clients. This will allow clients to move away from the smart transactions properties of the swaps feature flags which are deprecated.

Key Changes:

• Flag Source: Feature flags are now read directly from RemoteFeatureFlagController:getState instead of a getFeatureFlags callback.
• Validation Timing: Flags are validated when RemoteFeatureFlagController:stateChange fires
• Per-Chain Validation: Invalid chain configs are removed individually without affecting valid chains; errors are reported to Sentry via ErrorReportingService:captureException
• Unknown Chain Safety: Chains without explicit config return hardcoded disabled defaults (all flags false)
• Messenger Requirements: Clients must configure RemoteFeatureFlagController:getState, ErrorReportingService:captureException as allowed actions, and RemoteFeatureFlagController:stateChange as allowed event
• The getFeatureFlags constructor option is deprecated and ignored.

Links to draft migration PRs:

• Extension: feat(STX-331): replace legacy STX swaps flags with smart transaction flags from remote config API metamask-extension#38572
• Mobile: WIP

---

Note

Migrates smart-transactions feature flags to RemoteFeatureFlagController with per-chain validation, Sentry error reporting, new selectors, and controller changes that deprecate the getFeatureFlags option.

• Breaking:
  • Controller now reads flags via RemoteFeatureFlagController:getState and listens to RemoteFeatureFlagController:stateChange.
  • Requires allowing actions RemoteFeatureFlagController:getState, ErrorReportingService:captureException and event RemoteFeatureFlagController:stateChange in the messenger.
  • Deprecates and ignores getFeatureFlags constructor option.
• Feature Flags:
  • Add featureFlags module with validators (superstruct) and helpers to process flags, normalize chain IDs (hex/CAIP-2), and merge per-chain configs.
  • Introduce hardcoded DEFAULT_DISABLED_SMART_TRANSACTIONS_FEATURE_FLAGS fallback.
  • Export selectors selectSmartTransactionsFeatureFlags and selectSmartTransactionsFeatureFlagsForChain.
• Controller (src/SmartTransactionsController.ts):
  • Validates flags on feature-flag state changes and reports errors via ErrorReportingService:captureException.
  • Uses per-chain flags when deciding to mark regular transactions as failed; removes use of getFeatureFlags.
• Types & Exports:
  • Add and export SmartTransactionsNetworkConfig, SmartTransactionsFeatureFlagsConfig; update public index exports.
• Tests:
  • Add comprehensive tests for validators, feature-flag processing/selection, and controller error reporting and behavior.
• Docs:
  • README: document feature-flag management and how to add new flags.
• Dependencies:
  • Add @metamask/superstruct, @metamask/utils, reselect; add peer deps @metamask/remote-feature-flag-controller, @metamask/error-reporting-service.

^{Written by Cursor Bugbot for commit f0ffe63. This will update automatically on new commits. Configure here.}

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​metamask/​remote-feature-flag-controller@​2.0.1
	@​metamask/​error-reporting-service@​3.0.0

View full report