Merged
Conversation
…into feat--add-7715-discoverability-methods
mj-kiwi
reviewed
Jan 13, 2026
packages/smart-accounts-kit/src/actions/erc7715GetGrantedExecutionPermissionsAction.ts
Show resolved
Hide resolved
Member
V00D00-child
left a comment
There was a problem hiding this comment.
Looking good! Left some minor comments on using revised 7715 types, and there is a small merge conflict that needs resolution.
packages/smart-accounts-kit/test/actions/erc7715GetGrantedExecutionPermissionsAction.test.ts
Outdated
Show resolved
Hide resolved
…into feat--add-7715-discoverability-methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds ERC-7715 discoverability methods (
wallet_getSupportedExecutionPermissionsandwallet_getGrantedExecutionPermissions) to the smart-accounts-kit package, enabling applications to query wallet capabilities and previously granted permissions. It also includes refactoring to improve code organization and maintainability.🔄 What Changed?
List the specific changes made:
erc7715GetSupportedExecutionPermissionsActionto query supported permission types, chain IDs, and rule types from the walleterc7715GetGrantedExecutionPermissionsActionto retrieve all previously granted permissions that haven't been revokederc7715ProviderActionswithgetSupportedExecutionPermissionsandgetGrantedExecutionPermissionsmethodserc7715Types.tsfile (MetaMaskExtensionSchema,MetaMaskExtensionClient, result types)isDefined,assertIsDefined,toHexOrThrow) from the action file toutils.tsfor reuseMetaMaskExtensionSchemato include the new RPC method definitions🚀 Why?
Explain the motivation behind these changes:
utils.tsenables reuse across the codebase and follows DRY principles🧪 How to Test?
Describe how to test these changes:
List any breaking changes:
📋 Checklist
Check off completed items:
🔗 Related Issues
Link to related issues:
Closes #
Depends on: MetaMask/metamask-extension#39176
📚 Additional Notes
Any additional information, concerns, or context:
Note
Adds ERC‑7715 discoverability to
smart-accounts-kitand refactors shared types/utilities.erc7715GetSupportedExecutionPermissionsActionanderc7715GetGrantedExecutionPermissionsAction(RPC:wallet_getSupportedExecutionPermissions,wallet_getGrantedExecutionPermissions,retryCount: 0)erc7715ProviderActionswithgetSupportedExecutionPermissionsandgetGrantedExecutionPermissionsMetaMaskExtensionSchema,MetaMaskExtensionClient, and result types tosrc/actions/erc7715Types.ts; updates exports inindex.tsisDefined,assertIsDefined,toHexOrThrowintosrc/utils.tsand updateserc7715RequestExecutionPermissionsActionto use themWritten by Cursor Bugbot for commit d175f45. This will update automatically on new commits. Configure here.