generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 6
feat: Add system vats support with KernelFacet #803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rekmarks
wants to merge
15
commits into
main
Choose a base branch
from
rekm/system-vats-redux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b44a161
feat(ocap-kernel): Add KernelFacet
rekmarks 68bd8bb
feat(omnium-gatherum): Add system vats support
rekmarks 6800d87
refactor(omnium-gatherum): Convert bootstrap-vat to TypeScript
rekmarks cc82659
feat(kernel-browser-runtime): Add reset method to KernelFacade
rekmarks aa40a7b
refactor(omnium-gatherum): Rename bootstrap-vat to controller-vat
rekmarks 7a40714
fix(ocap-kernel): Avoid deadlock in E(kernelFacet) calls from within …
rekmarks e442969
feat(ocap-kernel): Add globals config for vat compartment endowments
rekmarks 079a10a
feat(omnium-gatherum): Add callCapletMethod API and simplify echo caplet
rekmarks eddfef7
chore(omnium-gatherum): Remove dead code from controller migration
rekmarks 286199a
fix(omnium-gatherum): Fix callBootstrap type annotations
rekmarks 052ebb0
fix(omnium-gatherum): Address review feedback
rekmarks 77adb05
fix(omnium-gatherum): Add console forwarding from kernel-worker and vats
rekmarks a5fac0d
refactor(omnium): Rename bootstrap vat to controller vat
rekmarks 4de3db8
test(ocap-kernel): Tweak kernel facet tests
rekmarks 3ff179d
fix(ocap-kernel,omnium-gatherum): Address PR review feedback
rekmarks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System vat roots not cleared on kernel reset
Medium Severity
The
#systemVatRootsmap is never cleared whenreset()is called. Afterreset()terminates all vats (including system vats) and resets the kernel store, the#systemVatRootsmap still contains stale krefs referencing terminated vats. Subsequent calls togetSystemVatRoot()return these invalid references, which would cause failures when attempting to use them.Additional Locations (1)
packages/ocap-kernel/src/Kernel.ts#L54-L55