feat: Bridge quotestream token warning events#8198
Open
infiniteflower wants to merge 10 commits intomainfrom
Open
feat: Bridge quotestream token warning events#8198infiniteflower wants to merge 10 commits intomainfrom
infiniteflower wants to merge 10 commits intomainfrom
Conversation
881e93d to
6d8a822
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The bridge-api SSE quote stream (
getQuoteStream) now emitstoken_warningevents alongsidequoteevents. These warnings come from Blockaid security scanning of the destination token and contain information like whether a token is a honeypot or has unstable pricing.Previously,
fetchBridgeQuoteStreamignored the SSEevent:name and attempted to validate every message as a quote response. This meanttoken_warningevents were silently dropped (or caused spurious validation failures).This PR:
fetchBridgeQuoteStream— onlyquoteevents go through quote validation,token_warningevents are validated separately via a new superstruct schema and routed to a dedicated handler, and all other event types are skipped.tokenWarnings: TokenFeature[]field toBridgeControllerState, populated from the SSE stream and cleared on reset / new quote fetch.onValidationFailuretoonQuoteValidationFailureand#trackResponseValidationFailuresto#trackQuoteValidationFailuresfor clarity now that there are multiple event types.TokenFeaturetype andTokenFeatureTypeenum for use by clients.References
va-mmcx-bridge-api-1Checklist
Note
Medium Risk
Changes the SSE quote-stream parsing/handlers and
BridgeControllerState, which can affect quote loading behavior and downstream consumers that assume only quote events or a fixed state shape.Overview
Adds support for
token_warningevents in the bridge-api SSE quote stream by routing events byevent:name infetchBridgeQuoteStream(quotes are validated/processed separately from warnings).BridgeControllerStatenow includestokenWarnings, which is reset on new quote requests andresetState, populated via a newonTokenWarningstream handler, and exposed via new exportedTokenFeature/TokenFeatureTypetypes. Quote validation failure handling is renamed toonQuoteValidationFailure/#trackQuoteValidationFailures, and tests/snapshots are updated with a warning-capable SSE mock.Written by Cursor Bugbot for commit 48b28d5. This will update automatically on new commits. Configure here.