Fix: QR rejection handling #156
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakra-guy
force-pushed
the
fix/qr-rejection-handling
branch
2 times, most recently
from
c580866 to
23dfed3
Compare
When users scan a QR code and reject the connection on MetaMask Mobile, the rejection error was not being propagated to the dApp. This fix ensures that error responses from the wallet are correctly identified and rejected with EIP-1193 compliant error codes (4001 = User Rejected Request). Changes: - Add error handling to initialConnectionMessageHandler for initial connections - Add error handling to handleMessage for ongoing requests - Create EIP-1193 compliant errors with code property - Update playground to display Legacy EVM errors in UI - Add unit tests for MWPTransport error handling Tested with: - Connect Multichain (QR code flow) - Connect Legacy EVM (QR code flow) - Wagmi connector (QR code flow)
- Replace manual error construction with providerErrors.custom() - Simplify initialConnectionMessageHandler with early returns - Reduce nesting depth from 5 levels to 2 levels - Remove code duplication between ID-based and method-based matching - Preserve wallet error codes while defaulting to 4001 (User Rejected)
- Close QR modal automatically when user rejects connection - Add wagmiError state to track Wagmi connection errors - Display Wagmi errors in the error section alongside Multichain and Legacy EVM
- Document QR rejection error propagation fix in connect-multichain - Document modal auto-close on rejection - Document Wagmi error display fix in browser-playground
chakra-guy
force-pushed
the
fix/qr-rejection-handling
branch
from
23dfed3 to
8a253fb
Compare
jiexi
reviewed
Feb 3, 2026
Comment on lines
+169
to
+170
| code: errorData.code ?? 4001, | ||
| message: errorData.message ?? 'Request rejected by user', |
Contributor
There was a problem hiding this comment.
not sure about these default values.
wow. so were we missing request.reject from errors this whole time? I guess that makes sense because I feel like the DefaultTransport has handling errors differently than the MWPTransport. sigh, good catch
jiexi
reviewed
Feb 3, 2026
Comment on lines
+446
to
+447
| code: errorData.code ?? 4001, | ||
| message: errorData.message ?? 'Connection rejected', |
Contributor
There was a problem hiding this comment.
not sure about these defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Problem
When users scan a QR code and reject the connection on MetaMask Mobile, the error was not propagated to the dApp. The connection would just hang instead of showing an error, and the QR modal would remain open.
Solution
Error Handling:
initialConnectionMessageHandler(for initial QR connections)handleMessage(for ongoing requests)@metamask/rpc-errors(providerErrors.custom()) for proper EIP-1193 compliant errors4001(User Rejected Request)Modal Behavior:
unload()on error)Playground Improvements:
Code Quality:
initialConnectionMessageHandlerto use early returns (reduced nesting from 5 to 2 levels)Testing
References
Checklist