feat: solana support #123

wenfix · 2026-01-20T13:36:59Z

Explanation

Introduces @metamask/connect-solana, a new package that wraps @metamask/solana-wallet-standard with MetaMask Connect, enabling Solana dapps to use MetaMask via the wallet-standard protocol. It also adds playground support for solana-wallet-standard which enables testing this feature.

Testing Steps

Install dependencies and build (yarn install && yarn build)
Launch browser playground (yarn workspace @metamask/browser-playground start)
Click Connect (Solana) button (ensure no extension is installed if using desktop browser)
IMPORTANT: Make sure Solana Devnet is permitted when accepting
Confirm connection -> Solana Card should appear in dapp
Try interactions available interactions such as sign, which should succeed.

References

Fixes WAPI-751

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

socket-security · 2026-01-20T13:37:46Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
@solana/wallet-standard-chains@1.1.1
@wallet-standard/base@1.1.0
@solana/wallet-adapter-react-ui@0.9.39
@solana/wallet-adapter-react@0.15.39
@metamask/utils@11.8.1 ⏵ 11.9.0	⁺¹	⁺¹	⁺²
@metamask/solana-wallet-standard@0.6.0

View full report

socket-security · 2026-01-20T13:37:48Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

@solana/[email protected]
@solana/[email protected]
@solana/[email protected]
@solana/[email protected]

View full report

wenfix · 2026-01-20T16:50:33Z

@SocketSecurity ignore npm/@solana/[email protected]
@SocketSecurity ignore npm/@solana/[email protected]
@SocketSecurity ignore npm/@solana/[email protected]
@SocketSecurity ignore npm/@solana/[email protected]

solana-devs is a known publisher of Solana related libraries.

packages/connect-solana/src/connect.ts

packages/connect-solana/package.json

packages/connect-solana/src/types.ts

packages/connect-solana/CHANGELOG.md

packages/connect-solana/src/types.ts

jiexi · 2026-01-26T19:22:23Z

packages/connect-solana/src/types.ts

+  };
+  /** Optional API configuration */
+  api?: {
+    /** A map of CAIP chain IDs to RPC URLs for supported networks */


should this be Solana Genesis Hash to RPC URLs?

🤔 also not following this one haha

playground/browser-playground/craco.config.js

package.json

packages/connect-solana/src/connect.test.ts

playground/browser-playground/src/components/SolanaWalletCard.tsx

jiexi · 2026-01-26T19:48:08Z

playground/browser-playground/src/App.tsx

+  const connectSolana = useCallback(async () => {
+    // Find the MetaMask wallet in registered wallets
+    const metamaskWallet = wallets.find((w) => 
+      w.adapter.name.toLowerCase().includes('metamask')


is there a chance this will perfer the extension announced event instead of the ConnectSolana one?

adonesky1 · 2026-01-28T22:42:13Z

Running into a build issue on the browser playground:

wenfix · 2026-01-29T12:53:51Z

Running into a build issue on the browser playground:

Adding Solana introduced [email protected] (ESM) alongside [email protected] (CJS), causing webpack bundling failures due to ESM/CJS interoperability issues with the base-x dependency.

Solution:

Force all packages to use [email protected] via yarn resolution.

This is safe because the bs58 API is identical across versions:

interface BS58 {  
  encode(source: Buffer | Uint8Array): string;  
  decode(string: string): Buffer;  // v4 returns Buffer  
  decodeUnsafe(string: string): Buffer | undefined;
}

The only difference is decode() return type:
v4/v5: Returns Buffer
v6: Returns Uint8Array

Since Buffer extends Uint8Array, code expecting Uint8Array works transparently with Buffer. All consumer packages (@metamask/solana-wallet-standard, @solana/web3.js, @walletconnect/utils, etc.) are compatible.

adonesky1 · 2026-01-29T20:11:01Z

I'm not seeing the sign **and** send flow working:

Each time I click it (even after repeated attempts) I get prompted to connect again (I think this has to do with devnet permissions not getting granted initially...? though I don't know why the connection request happens again and again then) but as you can see I don't ever get the subsequent signature request to show:

Screen.Recording.2026-01-29.at.2.08.38.PM.mov

wenfix · 2026-02-02T15:05:57Z

I'm not seeing the sign **and** send flow working:

Each time I click it (even after repeated attempts) I get prompted to connect again (I think this has to do with devnet permissions not getting granted initially...? though I don't know why the connection request happens again and again then) but as you can see I don't ever get the subsequent signature request to show:

Screen.Recording.2026-01-29.at.2.08.38.PM.mov

Yes, I've confirmed its due to the connection request not including the Solana Devnet scope. If you manually include it, you should see the tx confirmation pop-up. Let's discuss some of this during our standup today.

…let_createSession` call

adonesky1

LGTM!

adonesky1 · 2026-02-03T21:09:47Z

packages/connect-multichain/src/multichain/transports/default/index.ts

@@ -218,18 +227,12 @@ export class DefaultTransport implements ExtendedTransport {
        walletSession,
        proposedCaipAccountIds,
      );
+
      if (!hasSameScopesAndAccounts) {
        await this.request(
          { method: 'wallet_revokeSession', params: walletSession },
          this.#defaultRequestOptions,
        );
-        const optionalScopes = addValidAccounts(
-          getOptionalScopes(options?.scopes ?? []),
-          getValidAccounts(options?.caipAccountIds ?? []),
-        );
-        const createSessionParams: CreateSessionParams<RPCAPI> = {
-          optionalScopes,
-        };
        const response = await this.request(
          { method: 'wallet_createSession', params: createSessionParams },
          this.#defaultRequestOptions,
@@ -240,14 +243,6 @@ export class DefaultTransport implements ExtendedTransport {
        walletSession = response.result as SessionData;
      }
    } else if (!walletSession || options?.forceRequest) {
-      const optionalScopes = addValidAccounts(
-        getOptionalScopes(options?.scopes ?? []),
-        getValidAccounts(options?.caipAccountIds ?? []),
-      );
-      const createSessionParams: CreateSessionParams<RPCAPI> = {
-        optionalScopes,
-        sessionProperties: options?.sessionProperties,
-      };


Previously we weren't passing along sessionProperties in certain cases -> theoretically this could be its own PR but was causing an issue where Solana connection wasn't leading to additional network permissions being added as is expected (and currently happens in the injected script version)

wenfix added 2 commits January 20, 2026 13:30

add connect-solana

368f89f

add solana support to browser-playground

fa717a2

wenfix added 5 commits January 20, 2026 13:45

update changelogs

2f83664

fix changelogs

e35f4ac

add connect solana button to playground

5a6fd8c

update package.json keyword constraints validation

74a76f2

fix changelog

5905e2c

wenfix marked this pull request as ready for review January 20, 2026 15:10

wenfix requested a review from a team as a code owner January 20, 2026 15:10

wenfix added 3 commits January 20, 2026 15:14

add basic unit tests

61b0930

adjust vitest config

4b203d4

add test mocks

c5dffd4

adonesky1 reviewed Jan 20, 2026

View reviewed changes

packages/connect-solana/src/connect.ts Outdated Show resolved Hide resolved

jiexi reviewed Jan 23, 2026

View reviewed changes

packages/connect-solana/package.json Outdated Show resolved Hide resolved