fix: problems with validate on Windows with CRLF #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HowardBraham
force-pushed
the
windows-crlf
branch
from
207d2a0 to
f67b33f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had fixed some problems in #246, but validate was always saying "every single line is wrong" on Windows.
Note
Low Risk
Low risk: changes are limited to normalizing line endings before parsing/comparing, with added tests to prevent Windows-only formatting false positives.
Overview
Prevents
validateChangelogfrom reporting formatting errors solely due to Windows CRLF line endings by normalizing input/output line endings to LF before parsing and when comparing the formatted result.Adds regression tests covering CRLF changelog content (including when using the Prettier formatter) to ensure validation passes on Windows.
Written by Cursor Bugbot for commit f67b33f. This will update automatically on new commits. Configure here.