Skip to content

Conversation

@ccharly
Copy link
Contributor

@ccharly ccharly commented Feb 3, 2026

To avoid having to update every keyrings after we add a new capability.


Note

Medium Risk
Moderate risk because it changes the validation/typing contract for KeyringCapabilities.bip44 and updates multiple keyring wrappers/tests; consumers that relied on explicit false values may need to treat missing fields as unsupported.

Overview
Makes BIP-44 capability flags optional in KeyringCapabilities. The KeyringCapabilitiesStruct now treats bip44.derivePath, deriveIndex, deriveIndexRange, and discover as exactOptional(boolean()), so keyrings can omit unsupported capabilities instead of setting them to false.

Updates Ethereum keyring wrappers (HD/Ledger/QR/Trezor) and their tests to stop emitting/asserting false for unsupported BIP-44 capabilities, and documents the new semantics in the keyring-api changelog (and references the PR in downstream package changelogs).

Written by Cursor Bugbot for commit e152b20. This will update automatically on new commits. Configure here.

@ccharly ccharly requested a review from a team as a code owner February 3, 2026 17:59
@ccharly ccharly added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit f194ce6 Feb 3, 2026
37 checks passed
@ccharly ccharly deleted the cc/feat/relax-capabilities branch February 3, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants