generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 9
feat: use hw wallet error for ledger keyring and add getAppNameAndVersion and getAppConfiguration #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
montelaidev
wants to merge
17
commits into
main
Choose a base branch
from
feat/ledger-use-hardware-wallet-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
drfernandogomesreal-cpu
approved these changes
Jan 31, 2026
mathieuartu
reviewed
Feb 2, 2026
gantunesr
reviewed
Feb 2, 2026
gantunesr
reviewed
Feb 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a new method
getAppNameAndVersionandgetAppConfigurationto the ledger keyring and uses the hardware wallet errors.Examples
Note
Medium Risk
Updates Ledger bridge/keyring error semantics to throw
HardwareWalletErrorbased on SDK mappings and adds new bridge/keyring methods, which may affect downstream error handling and required implementations.Overview
Standardizes Ledger error handling on
@metamask/hw-wallet-sdk.keyring-eth-ledger-bridgenow depends on the SDK and replaces customTransportStatusError→LedgerStatusErrorlogic with mappedHardwareWalletErrorinstances (newerrors.ts+ updatedhandleLedgerTransportError), while keepingLedgerStatusErroras deprecated backwards-compatibility.Adds device introspection APIs. Extends
LedgerBridge/LedgerIframeBridge/LedgerMobileBridgeandLedgerKeyringwithgetAppNameAndVersion()andgetAppConfiguration(), including new iframe message actions and tests.Also tightens typing in
hw-wallet-sdkby exporting anErrorMappingtype, updates docs/config (READMEgraph,.syncpackrcworkspace pinning), and adjusts Jest coverage ignores/thresholds.Written by Cursor Bugbot for commit f42dc3b. This will update automatically on new commits. Configure here.