Skip to content

Conversation

@montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Jan 25, 2026

This PR add a new method getAppNameAndVersion and getAppConfiguration to the ledger keyring and uses the hardware wallet errors.

Examples


Note

Medium Risk
Updates Ledger bridge/keyring error semantics to throw HardwareWalletError based on SDK mappings and adds new bridge/keyring methods, which may affect downstream error handling and required implementations.

Overview
Standardizes Ledger error handling on @metamask/hw-wallet-sdk. keyring-eth-ledger-bridge now depends on the SDK and replaces custom TransportStatusErrorLedgerStatusError logic with mapped HardwareWalletError instances (new errors.ts + updated handleLedgerTransportError), while keeping LedgerStatusError as deprecated backwards-compatibility.

Adds device introspection APIs. Extends LedgerBridge/LedgerIframeBridge/LedgerMobileBridge and LedgerKeyring with getAppNameAndVersion() and getAppConfiguration(), including new iframe message actions and tests.

Also tightens typing in hw-wallet-sdk by exporting an ErrorMapping type, updates docs/config (README graph, .syncpackrc workspace pinning), and adjusts Jest coverage ignores/thresholds.

Written by Cursor Bugbot for commit f42dc3b. This will update automatically on new commits. Configure here.

@montelaidev montelaidev requested a review from a team as a code owner January 25, 2026 08:53
@montelaidev
Copy link
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link

Preview builds have been published. See these instructions (from the core monorepo) for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/account-api": "0.12.0-412b185",
  "@metamask-previews/hw-wallet-sdk": "0.2.0-412b185",
  "@metamask-previews/keyring-api": "21.3.0-412b185",
  "@metamask-previews/eth-hd-keyring": "13.0.0-412b185",
  "@metamask-previews/eth-ledger-bridge-keyring": "11.1.2-412b185",
  "@metamask-previews/eth-qr-keyring": "1.1.0-412b185",
  "@metamask-previews/eth-simple-keyring": "11.0.0-412b185",
  "@metamask-previews/eth-trezor-keyring": "9.0.0-412b185",
  "@metamask-previews/keyring-internal-api": "9.1.1-412b185",
  "@metamask-previews/keyring-internal-snap-client": "8.0.1-412b185",
  "@metamask-previews/eth-snap-keyring": "18.0.2-412b185",
  "@metamask-previews/keyring-snap-client": "8.1.1-412b185",
  "@metamask-previews/keyring-snap-sdk": "7.1.1-412b185",
  "@metamask-previews/keyring-utils": "3.1.0-412b185"
}

@montelaidev montelaidev changed the title feat: use hw wallet error for ledger keyring and add GetAppNameAndVersion feat: use hw wallet error for ledger keyring and add getAppNameAndVersion and getAppConfiguration Feb 2, 2026
@montelaidev montelaidev enabled auto-merge February 2, 2026 12:29
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants