Add cloud-related stash codes for GIIRSLW and GIIRSLW

[stemiglio]

This PR adds the stash codes for cloud that are needed by the varobs and cxfiles for GIIRSLW and GIIRSMW

[mikecooke77]

Is it worth adding any extra testing or is the code that uses this already well covered?

[stemiglio]

Is it worth adding any extra testing or is the code that uses this already well covered?

This addition is needed by VAR, which requires these additional variables in the varobs and cx files. If not present, VAR exits with an error. In my opinion this is a sufficient motivation for this PR, but let me know if you want me to do any additional tests.

[mikecooke77]

Is it worth adding any extra testing or is the code that uses this already well covered?

This addition is needed by VAR, which requires these additional variables in the varobs and cx files. If not present, VAR exits with an error. In my opinion this is a sufficient motivation for this PR, but let me know if you want me to do any additional tests.

Sorry I meant should a ctest or two be added to this repository to cover these additional variables? To make sure this configuration continues to work properly.

[stemiglio]

Is it worth adding any extra testing or is the code that uses this already well covered?

This addition is needed by VAR, which requires these additional variables in the varobs and cx files. If not present, VAR exits with an error. In my opinion this is a sufficient motivation for this PR, but let me know if you want me to do any additional tests.

Sorry I meant should a ctest or two be added to this repository to cover these additional variables? To make sure this configuration continues to work properly.

@mikecooke77 I see, now I understand what you mean. Actually I think everything is already being tested, I think the wording of my PR may have incorrectly given the impression that it was introducing new stash codes or varfields that were not used before. What I actually meant is that for GIIRS as well as other sensors there are a set of default cx fields and Var fields specified in the OPS code. But VAR also needs StashItem_cloud_bulk = 266, StashItem_Cl = 267 and StashItem_Cf = 268, as well as VarField_cloudtopp = 35, VarField_cloudfrac = 36 and VarField_BiasPredictors = 80, which are not included in the set of default fields. This is why for GIIRS I had to create ad hoc namelists in this PR that include these additional fields. Note that these additional fields are also needed by other satellite instruments, so no new field is introduced. As a matter of fact, the above mentioned fields are already being tested, see:
031_UpperAirCxField_cloud_bulk.yaml (https://github.com/MetOffice/opsinputs/blob/d7a42524fe652e5606d010c27f22884ebb6ba0c0/test/testinput/031_UpperAirCxField_cloud_bulk.yaml)
034_UpperAirCxField_Cf.yaml (https://github.com/MetOffice/opsinputs/blob/d7a42524fe652e5606d010c27f22884ebb6ba0c0/test/testinput/034_UpperAirCxField_Cf.yaml)
035_UpperAirCxField_Cl.yaml (https://github.com/MetOffice/opsinputs/blob/d7a42524fe652e5606d010c27f22884ebb6ba0c0/test/testinput/035_UpperAirCxField_Cl.yaml)
and
https://github.com/MetOffice/opsinputs/blob/d7a42524fe652e5606d010c27f22884ebb6ba0c0/test/testinput/035_VarField_cloudtopp.yaml
https://github.com/MetOffice/opsinputs/blob/d7a42524fe652e5606d010c27f22884ebb6ba0c0/test/testinput/036_VarField_cloudfrac.yaml
https://github.com/MetOffice/opsinputs/blob/d7a42524fe652e5606d010c27f22884ebb6ba0c0/test/testinput/080_VarField_biaspredictors.yaml

In conclusion, I think the answer to your question is that the code that uses this is already well covered

[mikecooke77]

Sounds good to me thanks for the detailed answer.