Skip to content

Rename SternaMWS as SternaMWR#244

Merged
matthewrmshin merged 2 commits intodevelopfrom
feature/awsrename
Jul 1, 2025
Merged

Rename SternaMWS as SternaMWR#244
matthewrmshin merged 2 commits intodevelopfrom
feature/awsrename

Conversation

@brettcandy
Copy link
Contributor

This is an update to ticket [] which introduced the Sterna MWS. Here S is for sounder, but ESA actually refer to it as a radiometer. So, to be consistent we rename the observation type as SternaMWR. This name will also be used for var/jada.

This change does the following

  • Renames obsgroup 70 to refer to SternaMWR
  • Updates the ctest for Sterna to conform to this name

@brettcandy
Copy link
Contributor Author

build and ctests work ok

Copy link
Collaborator

@ctgh ctgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Can you run the relevant KGO tests please?

Copy link
Collaborator

@mikecooke77 mikecooke77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me. Is this data part of any kgo's at the moment? Once you make it a full PR and add the ready to merge tag I'll merge. thanks.

@brettcandy
Copy link
Contributor Author

All good for me. Is this data part of any kgo's at the moment? Once you make it a full PR and add the ready to merge tag I'll merge. thanks.

Thanks - there are no kgos yet as its initial data. i will however check that the varobs are created correctly in my test sith run before setting ready to merge

@brettcandy
Copy link
Contributor Author

@brettcandy brettcandy marked this pull request as ready for review July 1, 2025 16:06
@matthewrmshin matthewrmshin merged commit 9666742 into develop Jul 1, 2025
7 of 8 checks passed
@matthewrmshin matthewrmshin deleted the feature/awsrename branch July 1, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants