Fix the test files to be the latest dateTime format#243
Merged
mikecooke77 merged 5 commits intodevelopfrom Jun 9, 2025
Merged
Conversation
mikecooke77
requested review from
DJDavies2,
adammaycock,
ctgh,
matthewrmshin and
yaswant
as code owners
DJDavies2
approved these changes
May 28, 2025
ctgh
approved these changes
Jun 2, 2025
Collaborator
ctgh
left a comment
ctgh
left a comment
There was a problem hiding this comment.
Thanks for making this change. The python looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #242
The old date times formats are being deprecated and will shortly be removed from the repository. I have updated the python script which generates the test files and recreated all the test files (hence the large number of files changed with this PR). I have built locally with the ioda branch attached to this PR https://github.com/JCSDA-internal/ioda/pull/1471. With this change all ctests pass.
This is just test data and will have no impact on any overnight running as there is no code change.