Conversation
DJDavies2
approved these changes
Apr 9, 2025
Contributor
Author
|
Tests i have created a new ctest for varobs writing for SternaMWS. i have also taken the code updates here and sucessfully built mo-bundle on EX machine We have SternaMWS data in the building and so i ran a version of sith with these new data and successfully wrote Varobs/Varcx files output here |
Contributor
Author
Contributor
Author
|
Ready to review - thanks |
adammaycock
approved these changes
Apr 12, 2025
Collaborator
|
@brettcandy For my information are you planning to add namelist files for EPSMWS as well? |
Collaborator
|
Looks good to me and its already got two reviews. If you are happy that no more changes are needed please add the "ready to merge" flag. |
Contributor
Author
i think i will add these namelists once we have actual data - in case something changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is a PR to allow the creation of varobs files using the opsinputs filters VarObs Writer and Varcx Writer for two new obsgroups, SternaMWS and EPSMWS Both are conventional MW sounders. As such there are no new varfields aor cx fields required. It is just small updates to allow the filters to recognise these new datasets
I have set these upto have the following obsgroups