Output bias corrected wind speeds for OceanWinds#233
Merged
mikecooke77 merged 2 commits intodevelopfrom Dec 12, 2024
Merged
Conversation
james-cotton
requested review from
DJDavies2,
adammaycock,
ctgh,
matthewrmshin,
mikecooke77 and
yaswant
as code owners
Collaborator
|
Presumably this will require sith and malak kgo updates? |
Contributor
Author
|
Hi Adam, I haven't added this obtype to SITH yet (in-progress at the moment) so no KGO updates. This is an observation type that hasn't been used operationally so has been a lower priority to port to JOPA. |
mikecooke77
reviewed
Dec 9, 2024
Collaborator
mikecooke77
left a comment
mikecooke77
left a comment
There was a problem hiding this comment.
I think the variable should be windSpeed? Is this varfield used for any other obstype?
Contributor
Author
|
That's just a typo in Varfields.md, I will fix that. This varfield has only been used (in recent memory at least) for testing ocean surface (10m) wind speed data e.g. from SMOS, GNSS-R. |
ctgh
approved these changes
Dec 11, 2024
DJDavies2
approved these changes
Dec 11, 2024
mikecooke77
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the ocean surface wind speed observations, we want to output
BiasCorrObsValue/WindSpeedto the Varobs file instead of the ObsValue. The ctest has been updated accordingly.