-
Notifications
You must be signed in to change notification settings - Fork 1
Enable-switching-off-CDDS-extract #300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
NParsonsMO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still working through the actual code changes, but have commented on some copyright stuff (and didn't want to lose this progress over lunch).
| DRS_OBS6="default" | ||
| ESMVALTOOL_MODULE_NAME="" | ||
| EXTRACT=true | ||
| EXTRACT_DATA_PATH="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's me, but I think this is actually more like "EXTANT_DATA_PATH", or something about "previously extracted".
"[To] extract" sounds like a command.
Not exactly but very close (Nikos changed that)
I don't feel qualified to say (Nikos: If you run the unit tests, they should complete successfully. Also, try all three cases (ACs) on your terminal with -O metoffice -O unittest, and should run for the different settings)
I've ticked this as I think it does
I've ticked this as I agree it didn't need to change
Nothing in doc has changed so I haven't ticked these |
Closes #282.
PR creation checklist for the developer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the developer
docdirectory) related to the change been updated appropriately, including the Quick Start section?PR creation checklist for the reviewer
<issue_number>above ☝️ been replaced with the issue number?mainbeen selected as the base branch?<issue_number>_<short_description_of_feature>?good first issuelabel) been added to the PR?Climate Model Evaluation Workflow (CMEW)project been added to the PR?Definition of Done for the reviewer
docdirectory) related to the change been updated appropriately, including the Quick Start section?