Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
description
@Deniz-Jasa & i paired a bit on this, and it looks like there's some nuance to the problem, but this reproduces the original problem & demonstrates that it's up to pagination not working.
notes
fun fact1: Temporal advises that page size limits are suggestions, not concrete guarantees. it turns out that concurrent execution will result in all history events returning in a single batch.
that is, if you modify the test workflow in this PR to call
Workflow.forConcurrently_then the test will pass!Footnotes
actually not fun! very annoying!! ↩