Skip to content

fix(plugin): update tools.allow via parsed object instead of raw string replacement #1378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CN-P5 wants to merge 1 commit into
base: openclaw-local-plugin-20260331
Choose a base branch
from
Open

fix(plugin): update tools.allow via parsed object instead of raw string replacement #1378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions apps/memos-local-openclaw/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ const memosLocalPlugin = {
try {
const pkg = JSON.parse(fs.readFileSync(path.join(pluginDir, "package.json"), "utf-8"));
pluginVersion = pkg.version ?? pluginVersion;
} catch {}
} catch { }
const telemetry = new Telemetry(ctx.config.telemetry ?? {}, stateDir, pluginVersion, ctx.log, pluginDir);

// Install bundled memory-guide skill so OpenClaw loads it (write from embedded content so it works regardless of deploy layout)
Expand Down Expand Up @@ -279,15 +279,9 @@ const memosLocalPlugin = {
const cfg = JSON.parse(raw);
const allow: string[] | undefined = cfg?.tools?.allow;
if (Array.isArray(allow) && allow.length > 0 && !allow.includes("group:plugins")) {
const lastEntry = JSON.stringify(allow[allow.length - 1]);
const patched = raw.replace(
new RegExp(`(${lastEntry})(\\s*\\])`),
`$1,\n "group:plugins"$2`,
);
if (patched !== raw && patched.includes("group:plugins")) {
fs.writeFileSync(openclawJsonPath, patched, "utf-8");
ctx.log.info("memos-local: added 'group:plugins' to tools.allow in openclaw.json");
}
cfg.tools.allow.push("group:plugins");
fs.writeFileSync(openclawJsonPath, JSON.stringify(cfg, null, 2) + "\n", "utf-8");
ctx.log.info("memos-local: added 'group:plugins' to tools.allow in openclaw.json");
}
}
} catch (e) {
Expand Down Expand Up @@ -607,9 +601,9 @@ const memosLocalPlugin = {
};
const localText = filteredHits.length > 0
? filteredHits.map((h, i) => {
const excerpt = h.original_excerpt.length > 220 ? h.original_excerpt.slice(0, 217) + "..." : h.original_excerpt;
return `${i + 1}. [${h.source.role}]${originLabel(h)} ${excerpt}`;
}).join("\n")
const excerpt = h.original_excerpt.length > 220 ? h.original_excerpt.slice(0, 217) + "..." : h.original_excerpt;
return `${i + 1}. [${h.source.role}]${originLabel(h)} ${excerpt}`;
}).join("\n")
: "(none)";
const hubText = filteredHubHits.length > 0
? filteredHubHits.map((h, i) => `${i + 1}. [${h.ownerName}] [团队] ${h.summary}${h.groupName ? ` (${h.groupName})` : ""}`).join("\n")
Expand Down