Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/memos/mem_feedback/feedback.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import difflib
import json
import re
import uuid

from datetime import datetime
from typing import TYPE_CHECKING, Any, Literal
Expand Down Expand Up @@ -236,6 +237,7 @@ def _single_add_operation(
else:
to_add_memory = new_memory_item.model_copy(deep=True)

to_add_memory.id = str(uuid.uuid4())
if to_add_memory.metadata.memory_type == "PreferenceMemory":
to_add_memory.metadata.preference = new_memory_item.memory

Expand Down Expand Up @@ -359,9 +361,14 @@ def semantics_feedback(
lang = detect_lang("".join(memory_item.memory))
template = FEEDBACK_PROMPT_DICT["compare"][lang]
if current_memories == []:
# retrieve
last_user_index = max(i for i, d in enumerate(chat_history_list) if d["role"] == "user")
last_qa = " ".join([item["content"] for item in chat_history_list[last_user_index:]])
user_indices = [i for i, d in enumerate(chat_history_list) if d["role"] == "user"]
if user_indices:
last_user_index = max(user_indices)
last_qa = " ".join(
[item["content"] for item in chat_history_list[last_user_index:]]
)
else:
last_qa = " ".join([item["content"] for item in chat_history_list])
supplementary_retrieved = self._retrieve(last_qa, info=info, user_name=user_name)
feedback_retrieved = self._retrieve(memory_item.memory, info=info, user_name=user_name)

Expand Down
Loading