Skip to content

Improve [Database] Initialize MYSQL Connection #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
H0llyW00dzZ wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve [Database] Initialize MYSQL Connection #378

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e50b7ec
Improve [Database] Initialize MYSQL Connection
H0llyW00dzZ Feb 18, 2025
0515810
Feat [Docs] [Database] Initialize MYSQL Connection
H0llyW00dzZ Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions cmd/template/dbdriver/files/service/mysql.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,20 @@ func New() Service {
dbInstance = &service{
db: db,
}

// Set a timeout for the Ping operation.
//
// TODO (H0llyW00dzZ): Use an environment variable to customize the timeout (e.g., "10*time.Second").
// For now, explicitly setting it to 10 seconds should be sufficient, as it is only used during initialization to avoid runtime confusion.
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
defer cancel()

// Note (H0llyW00dzZ): It's not possible to handle this without using log.Fatalf (e.g., by returning nil and fmt.Errorf("failed to connect database: %w", err))
// because the db.New function does not currently return an error. To improve error handling, the function db.New should be refactored to return an error,
// allowing the caller to manage it appropriately.
if err = db.PingContext(ctx); err != nil {
log.Fatalf("Failed to connect database: %v", err)
}
return dbInstance
}

Expand Down