Add werkzeug version in tests/requirements.txt file #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests/requirements.txt file
Contributor
|
Can you provide a link to the httpbin PR? Thanks! |
Contributor
Author
|
Of course, here it is : postmanlabs/httpbin#674 |
hemberger
approved these changes
Apr 6, 2022
Contributor
hemberger
left a comment
hemberger
left a comment
There was a problem hiding this comment.
LGTM, thanks! Once a new version of httpbin is released, we should probably remove this requirement though.
Collaborator
|
Merged. It may deserve a quick release, to avoid issues for people trying to install MechanicalSoup, but I won't have time to make it shortly. |
Contributor
|
It only affects the dev requirements, and I would expect anyone installing it in dev mode to be using the main branch instead of a release version. However, if you still think this warrants a release, I can make one. |
Collaborator
Ah, indeed, I forgot about that. Forget about the release, sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the continuous integration workflow, when pytest runs and calls httpbin, there was an incompatibility issue because httpbin imports a class called 'BaseResponse' from the werkzeug library. Werkzeug recently released a new version (2.1.0) removing this class because it's deprecated. Adding the condition
werkzeug < 2.1.0in the tests/requierements.txt file will temporarly solve the problem.I requested a PR in the httpbin library, but this little modification will avoid issues in the workflow.