Clang tidy false positives #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pin Ubuntu version, replace artifact download in lint step by newly creating the compile_commands * update readme to use alpha4 * fix gcovr bug * see: https://github.com/eclipse-uprotocol/up-cpp/actions/runs/13638110265/job/38121680150?pr=308#step:10:660
…ha4 (eclipse-uprotocol#305) * Adding subscriptions client header * Adding utils to build request inputs * Adding implementation for consumer * Adding subset of unit tests * Upgrade Consumer to alpha4 of up-spec. Co-authored-by: agosh01 <msagosh@gmail.com>
* Picking up debruce's commits to support google.protobuf.any in the payload builder: * Add constructor to Payload. Add test case to PayloadBuilderTest to exercise this constructor by creating an Any containing a uuri, passing it to the constructor, building it, and then deserializing the Any, and the contained uuri. * fix linting errors
…clipse-uprotocol#301) (eclipse-uprotocol#304) * Adding exception type for empty callback functions This exception will be thrown when an empty std::function is passed to the callback connection module. Adding the type first so that tests can be written. * Add callback tests for empty function objects * Fix null callback assertions in L2 tests Some L2 tests were asserting that the std::bad_function_call exception should be thrown when a bad callback is called. We will be changing that behavior so that the exception is thrown when the callback connection is established, requiring updated test cases. * Add empty function checks in CalleeHandle The CalleeHandle class is the "owner" of the callback function objects associated with a callback connection. As such, it will check the validity of those function objects and throw the EmptyFunctionObject exception if either the callback or cleanup function is empty / invalid. * Update include/up-cpp/utils/CallbackConnection.h Co-authored-by: Pete LeVasseur <plevasseur@gmail.com> * specify Clang version 17 in CI --------- Co-authored-by: Greg Medding <gregory.medding@gm.com> Co-authored-by: Pete LeVasseur <plevasseur@gmail.com>
MaximilianToe
force-pushed
the
clang-tidy-false-positives
branch
from
f12d180 to
4dc790c
Compare
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
|
Code coverage report is ready! 📈
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.