Open
Conversation
|
|
* Add benchmarks for basic ops (add, sub, mul, div, etc.) for the decimal types. * Use seeded rng for reproducible results. * Use a longer measurement period for more consistant results.
sploiselle
approved these changes
Oct 18, 2021
sploiselle
left a comment
sploiselle
left a comment
There was a problem hiding this comment.
Appreciate this expansion/tidying up. 12 and 16 are reasonable values to test Decimal<N> for so 👍 . No other suggestions for functions to add, but this makes further extensions much cleaner.
LGTM modulo unnesting imports.
Contributor
Author
I'm not exactly sure of what that means. I'm guessing you mean that you prefer a single import group per line. |
|
@jean-airoldie sorry about that, seems like my comment about the unnested imports didn't propagate as expected. You correctly inferred my meaning, though. tysm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This expands the benchmarks for the various number types. For the choice of operations, I used what was already benchmarked and I added functions I expect to be commonly used. Feel free to suggest anything else that could be relevent. I also wasn't too sure what sizes of
Decimal<T>to test for.One problem with the decimal generation approach I used is that the numbers are totally random and thus don't really follow any real world statistical distribution. This shouldn't be a big problem as long as the benchmark are only used to gauge relative improvement in performance etc.