-
Notifications
You must be signed in to change notification settings - Fork 25
updated naming format in py_tester.py #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated naming format in py_tester.py #605
Conversation
…-autotesting into refactor-test-name-format
david-yz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wkukka1 good work! However, it's probably better to parse the test's node id, for a few reasons:
- Prefer keeping the test relative path (rather than just filename)
- When the unit test is defined in a class rather than at the top level (in this case, I'd still like the class name to be displayed)
- Avoid accessing protected attributes
…matted python test name
|
Thanks for the feedback! For the unit tests should the format be [filename] classname.funcname |
Yes that's good 👍 |
for more information, see https://pre-commit.ci
…-autotesting into refactor-test-name-format
for more information, see https://pre-commit.ci
|
Updates:
|
david-yz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wkukka1 Okay this is great. Two additional comments:
- Please now make the same changes for the Jupyter tester.
- Please update the Changelog.
…-autotesting into refactor-test-name-format
for more information, see https://pre-commit.ci
…-autotesting into refactor-test-name-format


changed python test names to appear as [filename] testname.
results from running the autotest_py tests^