Skip to content

Conversation

@lizzie-liu
Copy link
Contributor

@lizzie-liu lizzie-liu commented Jan 24, 2026

Proposed Changes

  • Migrated the Grade Breakdown Summary Table in GradeBreakdownChart to use @tanstack/react-table v8
  • Updated the base Table component to:
    • Support initialState.columnVisibility for hidden columns
    • Conditionally render row for filters only when filters are enabled
  • Added tests for the GradeBreakdownChart component
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration) X

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@lizzie-liu lizzie-liu marked this pull request as ready for review January 24, 2026 20:47
@coveralls
Copy link
Collaborator

coveralls commented Jan 24, 2026

Pull Request Test Coverage Report for Build 21368497010

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 91.651%

Totals Coverage Status
Change from base Build 21339519388: 0.003%
Covered Lines: 44352
Relevant Lines: 47584

💛 - Coveralls

const columns = [
columnHelper.accessor("position", {
id: "position",
header: () => null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the rendering attributes are unnecessary, as the column will be hidden through the visibility setting.

header: () => null,
cell: () => null,
size: 0,
enableSorting: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not enable sorting for any columns; instead we'll keep the order fixed to be the position order (which matches what is shown in the grading view)

Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @lizzie-liu!

@david-yz-liu david-yz-liu merged commit 88127aa into MarkUsProject:master Jan 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants