-
Notifications
You must be signed in to change notification settings - Fork 253
Upgrade Grade Breakdown Summary Table to react-table v8 #7800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Grade Breakdown Summary Table to react-table v8 #7800
Conversation
…to allow for sorting by position
… existing tables using columnVisibility
…r if the table has no filters enabled)
Pull Request Test Coverage Report for Build 21368497010Details
💛 - Coveralls |
| const columns = [ | ||
| columnHelper.accessor("position", { | ||
| id: "position", | ||
| header: () => null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the rendering attributes are unnecessary, as the column will be hidden through the visibility setting.
| header: () => null, | ||
| cell: () => null, | ||
| size: 0, | ||
| enableSorting: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not enable sorting for any columns; instead we'll keep the order fixed to be the position order (which matches what is shown in the grading view)
david-yz-liu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, @lizzie-liu!
Proposed Changes
GradeBreakdownChartto use @tanstack/react-table v8Tablecomponent to:initialState.columnVisibilityfor hidden columnsGradeBreakdownChartcomponentScreenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)