MDEV-38195: Fix flaky events_restart and tmp_space_usage tests#4753
Open
varundeepsaini wants to merge 1 commit intoMariaDB:mainfrom
Open
MDEV-38195: Fix flaky events_restart and tmp_space_usage tests#4753varundeepsaini wants to merge 1 commit intoMariaDB:mainfrom
varundeepsaini wants to merge 1 commit intoMariaDB:mainfrom
Conversation
events.events_restart: Add missing error log suppressions for "error during compilation" and "Query was empty" that occur when the event scheduler processes events from a corrupted mysql.event table (body column altered to longtext). main.tmp_space_usage: The test compares tmp_space_used from session_status and processlist, but reads them at different times across a connection switch. Internal temp space changes (e.g. InnoDB page allocation) between reads cause small differences. Allow up to 32KB tolerance (two InnoDB pages) instead of requiring exact equality. Signed-off-by: Varun Deep Saini <varun.23bcs10048@ms.sst.scaler.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mtr.add_suppressionfor "error during compilation" and "Query was empty" errors that occur when the event scheduler processes events from a corruptedmysql.eventtable (body column altered to longtext during the test).tmp_space_usedfromsession_statusandprocesslistacross a connection switch. Between reads, internal temp space can change (e.g. InnoDB page allocation), causing small differences. Changed exact equality check to tolerate up to 32KB (two 16KB InnoDB pages).Test plan
events.events_restartpasses locallymain.tmp_space_usagepasses locally