Fix GN-453 stale sync overwrites #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add CRDT sync domain types with invariants: non-empty note/user ids, base64 update/snapshot, non-negative update ids - adapt handlers/adapters to construct at edges - remove interior defensive checks (validated once at boundary) - wrap errors with operation+subject+stable code (e.g., notes.apply_crdt_updates.missing_database) - CI: go vet/staticcheck/ineffassign/tsc --noEmit passing
…crdt-sync-implementation Implement GN-455 CRDT sync (no LWW fallback)
…crdt-ot-evaluation Document GN-454 CRDT/OT sync evaluation
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 103b57ce00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- add snapshot rebuilds for queued operations after remote updates/snapshots - adapt sync manager to pull snapshots from the CRDT engine - remove interior defensive checks (validated once at boundary): n/a - wrap errors with operation+subject+stable code (e.g., user.create.invalid_email): n/a - CI: make test/lint/ci; go vet/staticcheck/ineffassign; tsc --noEmit passing
…refresh-crdt-queue-snapshots Fix GN-456 queued CRDT snapshot refresh
…crdt-sync-implementation Maintenance/gn 455 crdt sync implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.