Fix DeprecationWarning: Update Adam optimizer 'lr' to 'learning_rate'#48
Open
antonyjasfer wants to merge 1 commit intoML4SCI:mainfrom
Open
Fix DeprecationWarning: Update Adam optimizer 'lr' to 'learning_rate'#48antonyjasfer wants to merge 1 commit intoML4SCI:mainfrom
antonyjasfer wants to merge 1 commit intoML4SCI:mainfrom
Conversation
Hi team! While reviewing the 2021 QCNN codebase, I noticed the model compilation step uses the deprecated lr argument in tf.keras.optimizers.Adam. In modern versions of TensorFlow (2.11+), this throws an AttributeError and crashes the notebook. I have updated it to the modern learning_rate argument to ensure forward compatibility. Let me know if you'd like me to check the other notebooks for similar Keras deprecations!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team! While reviewing the 2021 QCNN codebase, I noticed the model compilation step uses the deprecated lr argument in tf.keras.optimizers.Adam. In modern versions of TensorFlow (2.11+), this throws an AttributeError and crashes the notebook. I have updated it to the modern learning_rate argument to ensure forward compatibility. Let me know if you'd like me to check the other notebooks for similar Keras deprecations!