feat: Add model skeleton package with stubs for U-Net, noise schedule…#21
Open
KrishanYadav333 wants to merge 1 commit intoML4SCI:mainfrom
Open
feat: Add model skeleton package with stubs for U-Net, noise schedule…#21KrishanYadav333 wants to merge 1 commit intoML4SCI:mainfrom
KrishanYadav333 wants to merge 1 commit intoML4SCI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-GSoC groundwork for the "Denoising Astronomical Observations
of Protoplanetary Disks" project (GSoC 2026).
Following up on the config system PR, this lays out the model
module structure before any real implementation starts.
The idea is to define clean interfaces first so the next PRs (actual
forward pass logic, training loop, etc.) have a clear contract
to fill in rather than figuring out the structure mid-way.
All forward methods raise NotImplementedError for now — that's
intentional, not a bug.
What's included:
UNet— constructor signature with in_channels, base_channels,channel_multipliers, attention_levels, dropout
NoiseScheduler— q_sample, p_sample, p_sample_loop signatureswith full docstrings explaining what each method should do
DDPM— wrapper combining UNet + NoiseScheduler, exposestraining_loss and sample as the two main entry points
blocks.py— ResidualBlock, AttentionBlock, SinusoidalTimeEmbeddingstubs with documented args and return shapes
Files changed:
src/models/__init__.pysrc/models/blocks.pysrc/models/unet.pysrc/models/noise_scheduler.pysrc/models/ddpm.pytests/test_models_skeleton.pyLet me know if the interface design needs any changes before I
start filling in the implementations!