Custom Grid Vars & Extra Variables for llcreader#308
Draft
timothyas wants to merge 7 commits intoMITgcm:masterfrom
Draft
Custom Grid Vars & Extra Variables for llcreader#308timothyas wants to merge 7 commits intoMITgcm:masterfrom
timothyas wants to merge 7 commits intoMITgcm:masterfrom
Conversation
7cecd10 to
d03b3c6
Compare
Member
Author
|
Tests currently fail due to the issue described in #312. They do pass when the pytest fixture scope is set to "function", as described in that issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements two things:
mds_store: allow a user to add "on-the-fly" grid variables, or really any meta/data pair that does not have a 10 digit iteration number. For example, if we have a filesmooth2Dnorm001.meta/datain our run_directory:llcreader, add this capability and modified open_mdsdataset to add extra_variables #205 to add extra_variable meta information to an llcmodel, e.g.@cspencerjones: Hopefully with this PR my comment to #307 makes more sense. You could use this to add your SSU/SSV variables on-the-fly as with the extra_variables capability for mds_store. The only issue is if those SSU/SSV files are on a different grid, things will get more complicated, but if they're on the global grid this should work no problem.
I'll keep this as a draft for now because I need to add tests.