memleaks? #916
Closed
memleaks? #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
According to https://fortran-lang.org/learn/best_practices/allocatable_arrays/, these should be deallocated automatically. I don't really understand how this changes anything w.r.t. fragmentation. The deallocations inserted by the compiler should happen at the exact spot you have inserted them. |
Member
Author
|
You're right. I think we don't actually need these. I'll close the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding missing deallocates .. need to wait for tests to pass
I think modern fortran does handle this automatically to prevent memleaks, but explicit deallocates still help with Memory Fragmentation