[WIP] support for customizing LoRA weights through the sdapi#1982
Draft
wbruna wants to merge 1 commit intoLostRuins:concedo_experimentalfrom
Draft
[WIP] support for customizing LoRA weights through the sdapi#1982wbruna wants to merge 1 commit intoLostRuins:concedo_experimentalfrom
wbruna wants to merge 1 commit intoLostRuins:concedo_experimentalfrom
Conversation
Owner
|
Does it have any implications on memory use or runtime file loading? |
Author
|
For For |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still just an idea!
Since we just got support for multiple LoRAs, we could include LoRA customization on the API side, by:
/sdapi/v1/loraslorafileld at/sdapi/v1/txt2imgand/sdapi/v1/img2imgI recently implemented support on my Python client script for the mainline sd-server implementation, so I have a reasonable idea about how complicated that would be. I'm also aware that the sd.cpp C API would have to be adapted to allow changing LoRA weights without reloading the models.
Do you think this would be worth implementing?